Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: better support for ESM imports #850

Merged
merged 7 commits into from
Jun 11, 2024
Merged

feat!: better support for ESM imports #850

merged 7 commits into from
Jun 11, 2024

Conversation

porcellus
Copy link
Collaborator

Summary of change

  • Adds export mapping to make ESM imports more comfortable.
  • Adds test (added to CI as well) to ensure all files are importable.

Related issues

Test Plan

Added a new test file that is run during CI.

Documentation changes

N/A

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • If new thirdparty provider is added,
    • update switch statement in recipe/thirdparty/providers/configUtils.ts file, createProvider function.
    • add an icon on the user management dashboard.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the add-ts-no-check.js file to include that
  • If added a new recipe / api interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If added a new recipe, then make sure to expose it inside the recipe folder present in the root of this repo. We also need to expose its types.

anuragmerndev and others added 6 commits June 7, 2024 18:35
@anuragmerndev
feat: supporting esm import (#824)
eada4be 
* feat: supporting esm import
add the exports in package.json to support esm import for js and ts

* feat: support for .js module export
adding the support for .js module exports and support for types, nextjs, framework and recipe module exports
@porcellus
test: add a test to check our export mapping
d01e03d
@porcellus
fix: update export mapping
756dea3
@porcellus
chore: update version number
7326cbb
@porcellus
chore: add new related checklist item to PR template
4239c5b
@porcellus
fix: remove unnecessary/broken entry point
78beef5
@rishabhpoddar
Copy link
Contributor

@porcellus there is already a 19.0 branch, which @sattvikc is working on, so this can go in that and be released as part of that release.

@porcellus porcellus changed the base branch from 18.0 to 19.0 June 11, 2024 11:09
@porcellus porcellus merged commit 2f25f2f into 19.0 Jun 11, 2024
15 of 18 checks passed
@porcellus porcellus deleted the feat/support_esm_imports branch June 11, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@porcellus @rishabhpoddar @anuragmerndev